Implementing Controller Rebinding, Refactoring Controls System and Reworking Button Icons - #81
Merged
Merged
Conversation
…nstead of virtual button name. Adding new icons.
Creating control binding menu and setting up backend for updating bindings. Still very much a wip proof of concept. Sticks are still not supported, and there are probably several bugs.
Closed
Also adding actions for resetting and clearing bindings
Fixing missing dpad icons. Fixing issue with default deadzone not getting set or reset correctly. Fixing bug where Positive and Negative directions on an axis couldn't be bound to the same virtual button.
jasminegamedev
marked this pull request as ready for review
April 30, 2024 01:23
Collaborator
Author
|
I believe this is now working, and is ready to merge. There may still be a few binding issues, but some of these come from Foster, so we may want to look into fixing them separately. Mainly, a few keyboard keys don't seem to get registered as "Pressed" correctly, like the Windows button and the numlock button. I think this is probably acceptable for now, but we can revisit it if people complain. There's also a known bug in Foster with Controllers where the select and home buttons seem to be flipped. I have a temporary workaround for this, but we may need to follow up on this if it gets fixed in Foster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still Work in Progress and is not ready to merge yet.
This PR Implements Controller/Keyboard rebinding into the game. This includes new menus to handle the rebinding process, and reworking the backend systems as well to be able to support it.
This also reworks how we determine button icons to be based on the key/button name.
Todo:
Resolves #52