[4.0.0-beta desktop] CBL_AVAILABLE is True even when Couchbase Lite bindings are missing #248

try:
    from cbl_store import CBLStore, USE_CBL
    CBL_AVAILABLE = True          # always True if the .py file imported
except ImportError as e:
    CBL_AVAILABLE = False
    USE_CBL = False

# app.py
try:
    from cbl_store import CBLStore, USE_CBL
    CBL_AVAILABLE = bool(USE_CBL)
except ImportError as e:
    CBLStore = None  # type: ignore
    CBL_AVAILABLE = False
    USE_CBL = False
    logger.warning("cbl store unavailable: %s", e)

def storage():
    global _cbl_store
    if not CBL_AVAILABLE or CBLStore is None:
        return None
    if _cbl_store is None:
        try:
            _cbl_store = CBLStore()
            logger.info("cbl storage initialized")
        except Exception:
            logger.exception("cbl storage failed to initialize")
            return None
    return _cbl_store

# tests/python/test_cbl_availability.py
import importlib
from unittest.mock import patch
import pytest

def test_cbl_available_follows_use_cbl_flag(monkeypatch):
    import cbl_store
    monkeypatch.setattr(cbl_store, "USE_CBL", False)
    import app
    importlib.reload(app)
    assert app.CBL_AVAILABLE is False

def test_storage_returns_none_when_bindings_missing(monkeypatch):
    import app
    monkeypatch.setattr(app, "CBL_AVAILABLE", True)

    class Boom:
        def __init__(self):
            raise RuntimeError("CBLStore requires CBL bindings (import error: fake)")

    monkeypatch.setattr(app, "CBLStore", Boom)
    monkeypatch.setattr(app, "_cbl_store", None)
    assert app.storage() is None

def test_storage_info_is_json_error_not_traceback(client, monkeypatch):
    import app
    monkeypatch.setattr(app, "storage", lambda: None)
    res = client.get("/api/storage/info")
    assert res.status_code in (503, 500)
    body = res.get_json()
    assert body["success"] is False
    assert "CBL" in body["error"]