[4.0.0-beta desktop] Standalone app prints port 8888 but Flask binds 8080 #249

# app.py  (or a tiny app/ports.py so app_base can import it without a cycle)
DEFAULT_PORT = 8080

def get_server_port(default: int = DEFAULT_PORT) -> int:
    env = os.environ.get("PORT")
    if env:
        try:
            return int(env)
        except ValueError:
            logger.warning("ignoring invalid PORT env var=%s", env)
    cfg = _load_server_config().get("server") or {}
    val = cfg.get("port")
    if isinstance(val, int) and 0 < val < 65536:
        return val
    if isinstance(val, str) and val.isdigit():
        return int(val)
    return default

# app_base.py — stop inventing a second default
from app import get_server_port, DEFAULT_PORT  # or move helper to ports.py
PORT = get_server_port()

PORT = get_server_port()
print(f"🌐 Open http://localhost:{PORT} in your browser")

# tests/python/test_ports.py
import os
from unittest.mock import patch
from ports import DEFAULT_PORT, get_server_port

def test_default_port_is_8080():
    assert DEFAULT_PORT == 8080

def test_env_port_wins(monkeypatch):
    monkeypatch.setenv("PORT", "5555")
    assert get_server_port() == 5555

def test_invalid_env_port_falls_back(monkeypatch):
    monkeypatch.setenv("PORT", "not-a-port")
    with patch("ports._load_server_config", return_value={}):
        assert get_server_port() == DEFAULT_PORT

def test_config_json_port_used_when_no_env(monkeypatch):
    monkeypatch.delenv("PORT", raising=False)
    with patch("ports._load_server_config", return_value={"server": {"port": 9090}}):
        assert get_server_port() == 9090

def test_banner_port_matches_bind_port(capsys, monkeypatch):
    monkeypatch.setenv("PORT", "8080")
    import app
    # After fix, the printed URL must contain the resolved port, not 8888.
    # Assert via a small _startup_banner(port) helper:
    app._startup_banner(8080)
    out = capsys.readouterr().out
    assert "localhost:8080" in out
    assert "localhost:8888" not in out