Repository navigation
Centralize ParseJSON time display formatters (#228) - #264
Merged
Merged
Conversation
Move formatTime / formatTimeTooltip out of main-legacy into time-format.js (re-exported from ui-helpers.js). Replace remaining table/insight/chart .toISOString() display with formatTimestamp from base.js, and drop the hoisted local formatTimestamp duplicate that was shadowing the shared helper. close #228
Deploying cb-completed-request with
|
| Latest commit: |
6cd1fb7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://52d89bce.cb-completed-request.pages.dev |
| Branch Preview URL: | https://fix-issue-228.cb-completed-request.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes #228.
Duration display (
formatTime/formatTimeTooltip) now lives inapp/assets/js/time-format.jsand is re-exported fromui-helpers.js.main-legacy.jsuses the window bindings instead of an in-fileFormattersobject.Timestamp display goes through
formatTimestamp()inbase.js. Remaining table/insight/chart.toISOString().replace('T', ' ')…call sites were converted. The hoisted localformatTimestampin the AI timeline (which was shadowing the shared helper) is gone.Tests:
tests/formatters.test.jscovers MM:SS.mmm and tooltip contracts (1500ms→00:01.500,65000ms→01:05.000).