Skip to content

Conversation

@yannrichet-asnr
Copy link
Member

@yannrichet-asnr yannrichet-asnr commented Jan 25, 2026

Pull Request

Description

Brief description of what this PR does.

Related Issues

Fixes #(issue number)
Relates to #(issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test addition/modification

Changes Made

  • Change 1
  • Change 2
  • Change 3

Testing Performed

Automated Tests

  • All existing tests pass
  • Added tests for new functionality
  • Updated tests for modified functionality

Manual Testing

  • Tested on Linux
  • Tested on macOS
  • Tested on Windows

Test Coverage

# Paste relevant test output or coverage report
pytest tests/ -v

Documentation

  • Updated README.md
  • Added/updated docstrings
  • Updated CONTRIBUTING.md (if needed)
  • Updated INTERRUPT_HANDLING.md (if needed)
  • Added examples (if applicable)

Code Quality

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex code
  • No new warnings or linting errors
  • Removed debug code and print statements
  • Updated type hints (if applicable)

Breaking Changes

If this is a breaking change:

  • Described migration path in description
  • Updated version number appropriately
  • Added deprecation warnings (if applicable)

Screenshots/Examples

(If applicable, add screenshots or example output)

# Example usage
import fz
# ...

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes

Any additional information reviewers should know.

Copilot AI review requested due to automatic review settings January 25, 2026 22:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs code cleanup and sanitization, removing unused imports, consolidating duplicate code, and updating shell completions.

Changes:

  • Removed unused and redundant imports across multiple Python modules (runners.py, helpers.py, core.py, config.py, cli.py)
  • Consolidated duplicate format_time helper function by moving it to module level in helpers.py
  • Bumped version from 0.9.0 to 0.9.1
  • Added shell completion support for the fzl command in bash and zsh completion scripts

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
fz/runners.py Removed redundant local imports for os, getpass, and run_command that were already available at module level
fz/helpers.py Moved format_time function to module level and added uuid import at top; removed duplicate local function definitions
fz/core.py Removed unused imports (subprocess, tempfile, io, shutil, Union, Tuple, contextmanager, ThreadPoolExecutor, as_completed); removed unused exception variable; simplified string literals by removing f-string prefix where not needed
fz/config.py Removed unused Union import from typing
fz/cli.py Removed redundant local json imports (already imported at module level)
fz/_version.py Bumped version to 0.9.1 with updated commit date and hash
fz/init.py Updated version string to 0.9.1
completions/fz-completion.zsh Added fzl command completion support and updated documentation strings
completions/fz-completion.bash Added fzl command completion support and updated documentation strings
completions/README.md Updated documentation to include fzl command in examples and command list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yannrichet yannrichet merged commit 7f3481b into main Jan 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants