[RFR] Use $timeout to execute directive after $digest#39
Open
jpetitcolas wants to merge 1 commit intoFutureStateMobile:masterfrom
Open
[RFR] Use $timeout to execute directive after $digest#39jpetitcolas wants to merge 1 commit intoFutureStateMobile:masterfrom
jpetitcolas wants to merge 1 commit intoFutureStateMobile:masterfrom
Conversation
| scrollableContainer = $(window); | ||
| } | ||
| link: function(scope, element, attributes, control) { | ||
| $timeout(function () { |
There was a problem hiding this comment.
Why not using scope.$$postDigest()?
Contributor
Author
There was a problem hiding this comment.
$$ shows a private method for Angular. Thus, if we can prevent from using it... ;)
Contributor
|
I'm no longer doing Angular development, and I have no way of doing extensive testing of this directive, as I made it when I was working on a project for a different company that I no longer work for. I would like to keep it maintained however as there seems to be quite a few people using it. Would you like me to merge this patch? The other one has a bunch of merge conflicts and I don't feel like fixing them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using your directive with
ui-router. We got two different states (pages), each one having a sticky header. At first display (clicking on refresh button), everything works fine. Yet, when switching page, the header is not well displayed.This is due to the
$digestcycle. The sticky header is initialized before the DOM is fully rendered, causing some troubles with dimension computations. Adding a$timeoutwould wait for the whole DOM page to be rendered before executing thelinkfunction.