Skip to content

add pause on hover and copy to packet logger#29

Open
QDaves wants to merge 5 commits into
G-Realm:moonfrom
QDaves:logger-replay-copy
Open

add pause on hover and copy to packet logger#29
QDaves wants to merge 5 commits into
G-Realm:moonfrom
QDaves:logger-replay-copy

Conversation

@QDaves

@QDaves QDaves commented Jun 13, 2026

Copy link
Copy Markdown

packetlogger update
new option for autoscroll > pause on hover

[Copy]
copies the packet to the clipboard. with options what it should copy

@Lanflyy

Lanflyy commented Jun 14, 2026

Copy link
Copy Markdown

In my opinion the [Replay] is not up to the packet logger (which its functionality is just logging packets and making easier for the user to read and copy it). I believe reading some existing extension that already do that : (G-Trigger or maybe even the schedule of G-Earth).
Therefore, I doubt there is a high benefit of including it on this internal extension.

For the second functionality (advanced copy), there might be a benefit of having it with that approach indeed.
In my side I already started working on two different things :

  • Log retention : avoids a little bit memory get stacked up to reaches many GBs over the time, I mentioned this because I noticed you had to go over the same conclusion of including an object (here you named it LoggerControl) for each packet to manage actions individually for each packet. Which is good.
  • a small fix : stop auto-scroll when there is selection. Here I think we can get over the "stop auto scroll on hover" by just having this working

@Laande

Laande commented Jun 14, 2026

Copy link
Copy Markdown

I agree, the copy button is enough
The best thing would be to create a another extension like "advanced packet logger", whith all the possible functionnalites and keep the original one simple

@QDaves

QDaves commented Jun 14, 2026

Copy link
Copy Markdown
Author

ty for the feedback, makes sense so i removed replay again.
kept the pause on hover since its much smoother and sometimtes you jsut wanna look at it without selecting anything.

didnt fixed the deselect bug as i saw your other pr

@QDaves QDaves changed the title add replay and copy to packet logger add pause on hover and copy to packet logger Jun 14, 2026
@Lanflyy

Lanflyy commented Jun 14, 2026

Copy link
Copy Markdown

I tried to merge your changes over my branch that is not published yet, just to be prepared. But by checking the branch, I just noticed this is how it does look like :
image

  • There is no "user information" to confirm to the user he has indeed copied the concerned packet (UX).
  • the mouse does not transform into the "hand-finger" to show that part is clickable (UX).
  • (optional) There is no tiny highlight over that copy button when hovered by the mouse.

Also I am wondering, isn't this possible through a contextual menu when user would click right with the mouse ? Through that we can do so much more I believe.

@QDaves

QDaves commented Jun 15, 2026

Copy link
Copy Markdown
Author

there was a copy feedback in the statusbar, but tbh it was easy to miss.
made it now more clear with background highlighting and hand finger

also:

  • selection no longer gets wiped when packets come in
  • selecting text in the packet logger pauses autoscroll now too
Notepad_UrkMwFnD9G.mp4

kept it in one PR since we're both editing UiLoggerController to avoid conflict

@Laande

Laande commented Jun 15, 2026

Copy link
Copy Markdown

only if i had this back in my days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants