Remove debug Access-Control-Allow-Credentials header from ListObjects#144
Open
Remove debug Access-Control-Allow-Credentials header from ListObjects#144
Conversation
The `c.header("Access-Control-Allow-Credentials", "asads")` line in the
ListObjects handler sets an invalid value for the header (valid values
are "true" or the header should be omitted). This appears to be a debug
leftover. CORS is already properly handled by the hono cors() middleware
when enabled via config.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
r2-explorer-docs | d863a1e | Commit Preview URL Branch Preview URL |
Mar 07 2026, 04:45 PM |
Owner
Author
Automated Code Review — APPROVED ✅Review Scores: 5/5 reviewers approved SummaryReviewed the removal of a debug Review Perspectives
No issues found. Clean PR. 🤖 Automated review by prodboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
c.header("Access-Control-Allow-Credentials", "asads")from theListObjectshandler inpackages/worker/src/modules/buckets/listObjects.ts"asads"is not a valid value for this header (the only valid value is"true") and appears to be a debug/test leftovercors()middleware when enabled via thecorsconfig option insrc/index.tsWhy
This stray header sets an invalid value that browsers will ignore, but it's unnecessary noise in HTTP responses and could cause confusion when debugging CORS-related issues.
🤖 Generated with Claude Code