Repository navigation
perf(app-server): move TypeScript schema generation to protocol owner - #2277
Merged
limityan merged 1 commit intoAug 14, 2026
Merged
Conversation
limityan
marked this pull request as ready for review
August 14, 2026 06:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-app-server-protocolWhy
gen:typespreviously compiled both the protocol crate and the full App Server handler/runtime graph. In one recent Frontend Build sample, type generation occupied about 430s of a 484sbuild:webstep. This identifies a compilation hotspot; it is not presented as a guaranteed wall-clock improvement.Architecture and compatibility
bitfun-app-server-protocolremains behavior-light and does not depend on Core, Agent Runtime, or Services implementations.agent/submitDialogTurnnow has one canonical request type; the legacy message name is an alias of that same wire contract.bitfun_app_server::schemapreserves flat type paths and wire shapes as an internal compatibility re-export. Removed server-only inherent conversion helpers are not represented as a versioned public SDK guarantee..github/**is unchanged; no workflow or job was added.Dependency impact
Cargo.lockkeeps 1,159 package records with no additions, removals, upgrades, or downgrades. Only four direct dependency edges leave thebitfun-app-serverpackage record:bitfun-events,futures,tokio-util, andts-rs.Validation