fix(updater): require confirmation before installing downloaded updates - #2803
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Bug fix / UI/UX
Areas: Desktop/Tauri, Web UI, update caching and signature verification, capability registry, internationalization, documentation, and tests.
Motivation / Impact
Previously, accepting an update could trigger installation and application exit immediately after downloading, interrupting tasks that users continued or started during the download.
This change separates permission to download from permission to install and restart. Users can continue working during the download and explicitly choose when to install, without introducing task-completion scheduling or automatic restart logic.
Verification
Passed after rebasing:
pnpm run capabilities:check pnpm --dir src/web-ui exec vitest run src/infrastructure/update/updateInstallStore.test.ts src/infrastructure/update/installUpdateWithProgress.test.ts src/infrastructure/update/UpdateInstallProgressModal.test.tsx src/infrastructure/api/service-api/SystemAPI.test.ts src/infrastructure/api/generated/remoteSurface.test.ts git diff --cached --checkAll 27 tests across five files passed, covering confirmation, deferred installation, pending-update restoration, failure retries, duplicate-operation prevention, and controller-local routing.
Additional checks passed before rebasing:
The remote-surface contract suite passed all 19 tests.
Verification limitations:
cargo test -p openbitfun-desktop --lib api::update_api::testscompiled successfully, but the test executable encountered the known Windows/Tauri loader issueSTATUS_ENTRYPOINT_NOT_FOUNDbefore any tests ran.pnpm run check:core-boundarieswas blocked by an existing broken HarmonyOS link atentry/oh_modules/libbitfun_crypto.so.Reviewer Notes
ControllerLocal: installation targets the current desktop device and is not forwarded to a peer.install_updatecommand remains available for compatibility; the updated UI uses the staged commands.Checklist