test(app-server): fix context reload negotiation coverage - #2810
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the handshake test that expected
session/reloadContextwithout injecting its provider.Fixes #2694
Type and Areas
Type: Test / bug fix
Areas: Rust app-server integration tests and verification documentation.
Motivation / Impact
The integration test target failed to compile because its fixtures used outdated interfaces. After resolving those errors, the handshake test failed with
missing advertised method session/reloadContext.The test now supplies the provider required by its capability expectations and covers both provider-present and provider-absent cases.
No direct user-facing change.
Verification
cargo test --locked --offline -p openbitfun-app-server --test agent_kernel— 17 passed, 0 failed.pnpm run fmt:rs— passed.git diff --check— passed.Verification used local in-memory client/server transport. Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised.
Reviewer Notes
This fixes the test failure reported in #2694. The failure was reproduced without introducing the connection-timeout configuration change, so this fix does not establish the issue's proposed causal relationship.
Production behavior, protocol contracts, and persisted data formats are unchanged.
Checklist