Skip to content

feat(ui): unify picker controls and surface iconography - #2811

Merged
GCWing merged 1 commit into
1.0.0-explorefrom
gcwing/ui-control-surface-consistency
Sep 5, 2026
Merged

GCWing merged 1 commit into
1.0.0-explorefrom
gcwing/ui-control-surface-consistency

Conversation

@GCWing

@GCWing GCWing commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Upgrade shared Select and Combobox controls to use consistent anchored portal behavior, keyboard handling, field semantics, and compact sizing.
  • Extend the shared Icon contract for catalog and glyph sources, then normalize icon usage across navigation, settings, galleries, agents, skills, mini-apps, and related surfaces.
  • Update design tokens, Design Lab examples, locale copy, generated theme projections, and focused contract/integration coverage.

Fixes: N/A

Type and Areas

Type: UI/UX, refactor, test

Areas: design system, Web UI, desktop and MiniApp generated theme projections

Motivation / Impact

Users get consistent picker geometry and interaction behavior across settings and product surfaces, with a single icon ownership path instead of local adapters and one-off sizing. The new tests protect picker sizing, Select accessibility/keyboard behavior, icon integration, and appearance contracts.

Verification

  • pnpm run design-system:check — passed, including package builds, 244 UI tests, 60 Design Lab tests, token/theme/package contracts, and typography audit.
  • pnpm run check:web — passed, including type-check, Appearance contracts, typography, theme color, and visual governance.
  • Focused Web Vitest run — 12 files passed, 76 tests passed.
  • pnpm run i18n:audit — passed with 0 warnings.
  • pnpm run motion:audit — inventory reviewed; no changed-file blocker identified.
  • git diff --check origin/1.0.0-explore...HEAD — passed.
  • Browser automation, E2E, and manual rendered visual validation were not run, per repository guidance for this submission.
  • Remote workspace, Remote Control, Peer Device Mode, and Detached Dispatch were not exercised locally; this PR does not change transport, remote invocation, session lifecycle, paths, or protocol behavior.

Reviewer Notes

The branch was rebased onto the live 1.0.0-explore head before submission. One navigation conflict was resolved by preserving the upstream simplified recent-workspaces heading while retaining the shared Server icon used by the SSH action.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@GCWing
GCWing merged commit f85b64e into 1.0.0-explore Sep 5, 2026
11 checks passed
@GCWing
GCWing deleted the gcwing/ui-control-surface-consistency branch September 5, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant