Skip to content

fix(settings): preserve model detail contrast #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wsp1911 merged 1 commit into from
Sep 5, 2026
Merged

fix(settings): preserve model detail contrast #2814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/web-ui/src/infrastructure/config/components/ModelServiceCollapse.presentation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ describe('model service collapsed presentation', () => {
expect(modelSettingsStyles).toMatch(
/&__provider-group-header\s*\{[^}]*background:\s*transparent/,
);
expect(modelSettingsStyles).toMatch(
/\.openbitfun-collection-item__details\s*\{[^}]*background:\s*transparent/,
);
});

it('draws one consistent divider between provider headers and model rows', () => {
Expand Down
5 changes: 5 additions & 0 deletions src/web-ui/src/infrastructure/config/components/ModelSettingsPage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,11 @@

.openbitfun-collection-item__details {
border-top: 1px solid var(--openbitfun-color-border-subtle);
// The provider group owns the persistent surface. Reusing the shared
// translucent details tint here makes the dark-theme composite nearly
// identical to the surrounding scene, leaving a page-colored gutter
// around the dashed inset section.
background: transparent;
}

.openbitfun-collection-item__details-toggle {
Expand Down
Loading