fix(brand): preserve application icon artwork across surfaces - #2817
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the application artwork independently from the startup logo so asset regeneration keeps the application, window, launcher, and browser icons consistent. The desktop tray now reuses the configured window icon on every desktop platform.
Type and Areas
Regression fix — brand asset generation, desktop/Tauri, installer, web UI, mobile web, relay, and native mobile resources.
Motivation / Impact
Keep the silver application mark as its own source, regenerate the PNG/ICO/ICNS outputs, and remove the separate macOS tray template. Startup and in-product logo assets retain their existing source.
Verification
node --test scripts/generate-brand-assets.test.mjs— 10 tests passed.pnpm run fmt:rs --check— passed for the changed Rust file.cargo check -p openbitfun-desktop --lib— passed.git diff --check origin/1.0.0-explore...HEAD— passed.Reviewer Notes
AI-assisted; lightly tested with focused asset tests and a desktop compile check. Native tray appearance, including macOS light/dark menu bars, remains unverified.
Checklist