fix(config): accept OpenBitFun 1.0 prerelease configurations - #2830
Merged
Merged
Conversation
Apply the product-generation floor to the numeric version core so beta and nightly configurations written by OpenBitFun 1.0 can be loaded and imported. Keep product identity, schema, pre-1.0 rejection, and actual-version writes unchanged. Cover prerelease validation, load-save-restart cycles, explicit imports, and account-settings imports with focused regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow valid OpenBitFun 1.0 prerelease configurations to load by applying the product-generation floor to the numeric version core. Add regression coverage for beta/nightly load-save-restart cycles, explicit imports, and account-settings imports.
Related issue: none filed.
Type and Areas
Type: Bug fix / regression test
Areas: Rust core configuration; desktop startup
Motivation / Impact
OpenBitFun 1.0 beta builds persist their actual version, such as
1.0.0-beta.1, but the configuration reader rejects that value as older than OpenBitFun 1.0.0. A configuration written by the application can therefore prevent its next startup or fail an import. The reader now accepts the same product generation across stable and prerelease builds.Verification
cargo test -p openbitfun-core --no-default-features --lib service::config::: 122 passed with source version1.0.0, and 122 passed with the actual Cargo package version projected to1.0.0-beta.1.node --test scripts/release-channel.test.mjs OpenBitFun-Installer/scripts/build-installer.test.cjs: 12 passed.build-installer.bat: the complete local Windows release build passed with version1.0.0-beta.1.1.0.0-beta.1, and language/theme settings survived restart.0.9.9configuration is still rejected without changing its bytes. The existing user configuration remained unchanged.git diff --check: passed.Reviewer Notes
The product identity, schema, protected metadata, retired-field rejection, and pre-1.0 floor remain enforced. Saves still record the actual package version. Release-channel validation and updater version ordering are unchanged; no configuration migration or reset is introduced.
AI-assisted. Testing level: fully tested for the focused configuration behavior and Windows packaged runtime described above. Installer installation/upgrade actions, macOS/Linux runtime behavior, and live remote workspace, remote control, peer-device, and detached-dispatch scenarios were not exercised. Account-settings import is covered by feature-free Core fixtures.
Checklist