Skip to content

fix(nav): prefer connection aliases in remote workspace badges #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobleer merged 1 commit into from
Sep 6, 2026
Merged

fix(nav): prefer connection aliases in remote workspace badges #2844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/web-ui/src/app/components/NavPanel/sections/workspaces/WorkspaceItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ const WorkspaceItem: React.FC<WorkspaceItemProps> = ({
return {
status,
statusLabel,
hostLabel,
connectionLabel,
/** A green dot already reads as "fine"; spell out only the states that need attention. */
showStatusText: status !== 'connected',
tooltip: t('nav.workspaces.remote.tooltip', {
Expand All @@ -261,7 +261,7 @@ const WorkspaceItem: React.FC<WorkspaceItemProps> = ({
status: statusLabel,
}),
ariaLabel: t('nav.workspaces.remote.ariaLabel', {
connection: hostLabel,
connection: connectionLabel,
status: statusLabel,
}),
};
Expand Down Expand Up @@ -1362,7 +1362,7 @@ const WorkspaceItem: React.FC<WorkspaceItemProps> = ({
aria-hidden="true"
/>
<span className="openbitfun-nav-panel__workspace-item-remote-host">
{remoteMeta.hostLabel}
{remoteMeta.connectionLabel}
</span>
{remoteMeta.showStatusText ? (
<span className="openbitfun-nav-panel__workspace-item-remote-status">
Expand Down
2 changes: 1 addition & 1 deletion ...web-ui/src/app/components/NavPanel/sections/workspaces/WorkspaceListSectionLayout.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ describe('WorkspaceListSection layout styles', () => {
expect(source).toContain('behavior="marquee"');
expect(searchIndicatorStart).toBeGreaterThan(remoteNameStart);
expect(remoteMetaStart).toBeGreaterThan(searchIndicatorStart);
expect(remoteMetaMarkup).toContain('remoteMeta.hostLabel');
expect(remoteMetaMarkup).toContain('remoteMeta.connectionLabel');
expect(remoteMetaMarkup.indexOf('workspace-item-status-dot'))
.toBeLessThan(remoteMetaMarkup.indexOf('workspace-item-remote-host'));
expect(source).not.toContain('workspace-item-subtitle');
Expand Down
Loading