fix(desktop): match DMG background resolution to Finder layout - #2852
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the macOS DMG background rendering at 495×300 points inside the configured 660×400 window, leaving white space along the right and bottom and misaligning the artwork with the installer icons.
Change only the PNG physical-resolution metadata from 96 DPI to 72 DPI. Extend the existing packaging test to compare the background's physical dimensions with the Finder window.
Type and Areas
Type: bug fix
Areas: desktop/Tauri, macOS installer, packaging tests
Motivation / Impact
Finder reads the background's physical dimensions rather than its pixel dimensions alone. The existing 660×400 PNG was tagged at 96 DPI, so macOS displayed it at 75% of the intended size. At 72 DPI, macOS reads it as 660×400 points, matching the configured layout.
Verification
node --test scripts/desktop-tauri-build.test.mjs— all 18 tests passed.pnpm run theme:color-audit:all— all 22 selected surfaces passed.git diff --check— passed.NSImagecheck: the original asset reads as 495×300 points; the updated asset reads as 660×400 points.pHYsis byte-for-byte unchanged, including image pixel data.Reviewer Notes
AI-assisted; lightly tested, with focused automated checks and native image-size verification. The regression assertion accounts for PNG's integer pixels-per-metre rounding.
Checklist