fix(desktop): align macOS traffic lights with toolbar icons - #2856
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust the macOS native traffic-light vertical position from 15 to 22.5 logical pixels to align with the 45px toolbar row.
Related issue: N/A.
Type and Areas
Type: Bug fix / UI/UX
Areas: Desktop / Tauri (macOS)
Motivation / Impact
The native close, minimize, and fullscreen buttons appear above the other toolbar icons on macOS. Move them down by 7.5 logical pixels while preserving their horizontal spacing.
Verification
pnpm run fmt:rs— passed.git diff --check— passed.cargo check -p openbitfun-desktop --offline— passed on Windows.pnpm --dir src/web-ui exec vitest run src/app/layout/WorkspaceBody.presentation.test.ts— 4 tests passed.@openbitfun/token-engineworkspace dependency; the focused tests passed when invoked directly.Reviewer Notes
Checklist