fix(skills): match marketplace installs by repository and skill name - #2869
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect installed indicators for marketplace skills that share a name across different repositories.
Read repository provenance from existing installer lock files and use repository plus skill name consistently for cards, details, install buttons, and sorting.
Type and Areas
Type: Bug fix
Areas: Rust core, Agent Runtime contracts, Web UI, tests
Motivation / Impact
Installing one
eli5skill previously marked unrelatedeli5listings as installed and disabled their install buttons.Only the matching repository and skill now receive installed status. Existing skills without provenance remain available without being matched by name alone.
Verification
All checks passed:
pnpm run fmt:rsgit diff --checkpnpm run check:webpnpm --dir src/web-ui exec vitest run src/infrastructure/config/skillMarketInstallation.test.ts src/app/scenes/skills/hooks/useSkillMarket.test.tsx src/app/scenes/skills/SkillsScene.presentation.test.tscargo test --locked -p openbitfun-agent-runtime --no-default-features --features agent-runtime --test agent_definition_contracts skill_contracts::cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,git --lib agentic::tools::implementations::skills::Reviewer Notes
installationSourceis optional and supports legacy payloads.Checklist