feat: restore Flashgrep with release-based binary downloads - #2895
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore local workspace search and its settings, fetching Flashgrep binaries from a public binary-only GitHub release instead of committing executables. Desktop CI, local packaging, and the Windows installer include only the binary for their target architecture.
Type and Areas
Type: Feature restoration, bug fix, CI
Areas: Desktop/Tauri, Web UI, workspace search services, installer, packaging, development scripts
Motivation / Impact
OPENBITFUN_DEV_PORT/OPENBITFUN_DEV_HMR_PORT.Verification
Re-run after rebasing onto upstream main:
node --test scripts/dev-startup.test.mjs scripts/prepare-flashgrep-resource.test.mjs scripts/desktop-tauri-build.test.mjs scripts/prepare-dsh-profile.test.mjs— 39 passed.pnpm --dir src/web-ui exec vitest run src/infrastructure/config/components/RuntimeSettingsPages.test.tsx src/app/global-search/providers/interactiveCapabilitySearchProvider.test.ts src/tools/file-explorer/search/useWorkspaceSearchIndex.test.ts— 31 passed.pnpm exec tsc --noEmit -p src/web-ui/tsconfig.json— passed.pnpm run capabilities:generate,pnpm run check:github-config,pnpm run check:core-boundaries, andgit diff --check— passed.Earlier focused verification on this change:
cargo test -p openbitfun-desktop --no-default-features --lib appearance::development_frontend_testswith cached Sherpa libraries — 2 passed.Reviewer Notes
Full platform packaging is left to CI. Remote-workspace rejection is covered by unit tests; no live SSH, remote-control, peer-device, or detached-dispatch end-to-end session was exercised. This does not add remote Flashgrep support.
Checklist