feat(web-ui): add workspace session tabs and rolling text - #2896
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep one stable session tab per owning workspace and device surface. Opening another session replaces that workspace's reference, while other tabs retain their titles and order. Workspace activation, session hydration, history navigation, and close fallback share one navigation transaction, and all session tabs use a single presentation host.
Add the public RollingText component and TabGroup label transitions, reuse them in the welcome surface, keep sidebar ordering tied to execution activity, and simplify the auxiliary canvas empty state and workspace resource panel.
Type and Areas
Feature, UI/UX, refactor, docs, and tests. Areas: Web UI session navigation, design system, Design Lab, localized welcome copy, and generated Data Migrator theme tokens.
Motivation / Impact
Users can retain their current session in each workspace without background labels following the active session. Superseded asynchronous navigation cannot select a stale destination, and switching tabs preserves the existing file, terminal, voice, and customization scene contracts. Session title edits remain static; replacing the referenced session uses interruptible motion that respects reduced-motion preferences.
Verification
GitHub CI run 34216519048 passed for
ae5e93cf4a9f4e36caa6ecfe70e4c6ba38d34c56, including the full Web UI suite/build and Rust/CLI checks on Linux, macOS, and Windows. Repository Object Sizes also passed. The two impact-selected packaging jobs were skipped by the existing workflow.Passed locally on Windows with Node.js 22.18.0 and pnpm 10.15.0:
pnpm run design-system:checkpnpm run check:webpnpm run lint:web(0 errors; 11 existing warnings)pnpm run theme:color-audit:all(23 surfaces)pnpm run i18n:audit(0 warnings)pnpm run motion:audit(intent inventory)node scripts/check-git-object-sizes.mjs --base origin/main --head HEADgit diff --check origin/main...HEADpnpm --dir src/web-ui exec vitest run --maxWorkers=50% src/flow_chat/services/openBtwSession.test.ts src/infrastructure/creation/creationBridge.test.ts src/flow_chat/services/sessionActivation.test.ts src/app/services/sessionSceneLifecycle.test.ts src/app/stores/sceneStore.test.ts(5 files, 57 tests passed).Focused regression command
pnpm --dir src/web-ui exec vitest run --maxWorkers=50% src/app/services/sessionSceneLifecycle.test.ts src/flow_chat/services/sessionActivation.test.ts src/flow_chat/services/storeSync.test.ts src/app/stores/sceneStore.test.ts src/app/services/sessionSceneTarget.test.ts src/app/hooks/useSessionTabLabels.test.tsx src/app/components/NavPanel/workspaceSessionView.test.ts src/app/components/NavPanel/sections/sessions/sessionNavSelection.test.ts src/app/components/SceneBar/SceneBar.test.tsx src/app/scenes/SceneViewport.test.tsx src/app/scenes/workspace-resources/workspaceResources.test.ts src/app/global-search/globalSearchArchitecture.test.ts src/flow_chat/services/flow-chat-manager/SessionModule.test.ts src/flow_chat/services/sessionNavStatusService.test.ts src/flow_chat/utils/workspaceScope.test.ts src/flow_chat/utils/sessionNavOrdering.test.ts src/shared/services/sceneOpenTargetResolver.test.ts src/infrastructure/design-system/RollingTextIntegration.test.tsxReviewer Notes
AI-assisted; tested with local build, type, contract, and unit checks. Visual fidelity was not verified through browser automation or mock screenshots, in accordance with repository guidance. Native visual checks remain separate from these results.
Tests cover legacy workspace metadata, worktree ownership, SSH host/path identity, device-surface isolation, and superseded selection. No live Remote Workspace, Remote Control, Peer Device Mode, or Detached Dispatch integration scenario was exercised locally. Persisted session shapes and wire protocols are unchanged.
Checklist