Repository navigation
fix(ui): align form labels and grouped surfaces - #2909
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Bug fix / UI/UX
Areas: Design system, Web UI, Appearance themes, Design Lab
Motivation / Impact
Form labels previously used the same typography regardless of orientation, while helper text and section descriptions lacked the intended visual hierarchy. Grouped forms also inherited an opaque container background.
This change makes form typography and grouped surfaces consistent with the design specifications across shared components and product forms.
Verification
The original implementation passed:
pnpm run design-system:checkpnpm run check:web, including theme audits and TypeScript checksThese results apply to the original commit; checks have not been rerun on the current cherry-picked revision.
Manual review locations: Design Lab → Patterns → form typography, product settings, and the new-workspace dialog. Full theme, density, narrow-window, and remote-scenario verification remains pending.
Reviewer Notes
Legacy Appearance packages retain their existing grouped-surface overrides unless they explicitly provide the new token. Compatibility applies to both root and chrome scopes.
No backend protocol or persisted schema changes are introduced. Generated theme CSS is updated from its source tokens.
Checklist