Repository navigation
fix(ui): align global search dialog composition - #2935
Merged
Merged
Conversation
Share the 800 by 460 search scene contract between Lab Patterns and the product. Scope the 30px query height to its shell, replace scope buttons with the public small TabGroup, and remove superseded query and responsive spacing overrides. Keep the results scrollbar at the dialog edge and shrink insets in narrow windows. Lab: Patterns > search command surface, with scope selection and scrolling results. Product: Ctrl K global search. Validation: design-system:check, check:web, and 16 tests across globalSearchArchitecture, globalSearchShortcut and globalSearchResultPresentation passed. Native desktop confirmed target geometry, keyboard scope navigation, empty state and Escape close; full IME cancellation, narrow-window and long-result combinations remain manual follow-ups. Remote: no four-scenario end-to-end verification. Search providers and activation adapters are unchanged; embedded search keeps its regular query size. No persisted shape changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the global search dialog and Design Lab preview around shared layout tokens.
Type and Areas
Type: Bug fix / UI/UX
Areas: Web UI, design tokens, Design Lab, generated data-migrator theme CSS.
Motivation / Impact
The global search dialog used custom sizing and spacing that differed from the design system. Shared geometry and controls make the product and Lab preview consistent while preserving keyboard scope navigation and responsive insets.
The compact search-field height applies only to the modal; embedded search retains its existing size.
Verification
Previously recorded implementation checks passed; they were not rerun when preparing this PR description:
pnpm run design-system:checkpnpm run check:webpnpm --dir src/web-ui run test:run src/app/global-search/globalSearchArchitecture.test.ts src/app/global-search/globalSearchShortcut.test.ts src/app/global-search/globalSearchResultPresentation.test.ts— 3 files, 16 tests passed.
Native Windows desktop checks covered dialog geometry, keyboard scope navigation, the empty state, and Escape dismissal.
Full IME cancellation, narrow-window layouts, and long-result combinations remain pending.
Reviewer Notes
Product entry: Ctrl+K global search.
Lab entry: Patterns → search command surface.
Search providers and activation adapters are unchanged. No backend commands, protocol changes, or persisted-data migrations are introduced.
Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not verified end to end.
Checklist