Repository navigation
fix(mobile): align native login panels and QR connection flows - #2966
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align native Android, iOS, and HarmonyOS connection flows, including compact GitHub login panels and app-owned QR scanning on Android.
Type and Areas
Type: UI/UX, bug fix, tests
Areas: Native Android, iOS, HarmonyOS, mobile design system, shared mobile account state
Motivation / Impact
The same connection action previously opened different layouts across mobile platforms. GitHub login also occupied nearly the whole screen despite having only a short explanation and one action. All three now use the same compact panel geometry; Android QR scanning stays inside the app and follows the existing native scanner layout.
Measured native screenshots at a 402 × 874 logical viewport show a 386 × 280 login panel on all three platforms. Wide layouts use 560 × 280 panels. System safe-area offsets and native font rasterization remain platform-specific; this is not a claim of identical full-screen pixels.
Verification
Passed during implementation:
pnpm run mobile:ui:checkpnpm run mobile:architecturepnpm run theme:color-audit:all— all 23 selected surfaces./gradlew :app:assembleDebug :app:testDebugUnitTest./gradlew :app:connectedDebugAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=com.openbitfun.mobile.app.ConnectionSheetChromeTest— 3 tests, including phone/wide panel geometry, action positions, CJK line boxes and click handlingInlineQrDecoderTest— bundled decoder recognizes a generated QR fixture and rejects a blank imagexcodebuild -project OpenBitFun.xcodeproj -scheme OpenBitFun -destination 'platform=iOS Simulator,name=iPhone 17 Pro' CODE_SIGNING_ALLOWED=YES CODE_SIGNING_IDENTITY=- buildscripts/ohos-env.sh,"$HVIGORW" --mode module -p product=default -p module=entry@default assembleHap --no-daemongit diff --checkManual simulator checks: Android phone/wide layouts and 1.5× text; iPhone/iPad and accessibility-large text; HarmonyOS folded/unfolded transitions while the login panel is open; dismissal/back navigation; camera permission-denied UI; Android camera active → released during manual pairing → resumed → released on close.
Reviewer Notes
Changes affect the local native presentation of remote-control entry points. Real GitHub authorization and end-to-end remote workspace, Peer Device, and Detached Dispatch connections were not exercised. No credentials, user data migrations or wire-protocol changes are included. Local screenshot reports are intentionally not committed.
Checklist