Repository navigation
feat(web): add looping localized welcome typewriter - #2970
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the welcome page's three-phrase fade, which stops on the final phrase, with an infinite typewriter loop. Each complete phrase is typed, held for 2.2 seconds, and erased before the next phrase, with a blinking cursor.
Keep the logo and OpenBitFun title stationary by reserving space for the longest phrase. Expand the rotation to seven phrases and localize all copy in Simplified Chinese, Traditional Chinese, and English, including “创造不可能。” / “Create the impossible.” and “让梦想开出花。” / “Let dreams bloom.” New phrases are translated as complete sentences rather than concatenated with the English “space.” suffix.
Type and Areas
Type: UI/UX feature
Areas: Web UI welcome scene, i18n resources
Motivation / Impact
Make the tabless welcome surface feel more lively while preserving its existing branding and theme tokens. Pause typing while the document is hidden, restart with translated copy when the locale changes, and show the static invitation with no blinking cursor when reduced motion is preferred. Screen readers retain a stable heading instead of receiving per-character updates.
Verification
pnpm run lint:web— passed after correcting the timer callback declaration; only an existing unrelated editor warning remains.pnpm run check:web— passed, including type checking and appearance/theme governance.pnpm run i18n:audit— passed with zero warnings.pnpm run motion:audit— reviewed the informational inventory; the welcome cursor has a local reduced-motion override. The report's existing unrelated PortForwardDialog finding is unchanged.git diff --check— passed.Local browser preview — inspected the welcome page, cursor, phrase rotation, and reserved layout width; confirmed seven localized phrases load.
Remote workspace, Remote Control, Peer Device Mode, and Detached Dispatch were not exercised. This change is presentation-only and adds no host calls or protocol changes.
Reviewer Notes
AI-assisted implementation; testing level: lightly tested (local automated checks and browser inspection, no full desktop/platform or remote matrix). No new dependencies or persisted data changes.
Checklist