Skip to content

refactor(ui): adopt shared overflow, tabs, and market navigation components - #3013

Merged
kev1n77 merged 4 commits into
GCWing:mainfrom
kev1n77:fmy/ui-main
Sep 14, 2026
Merged

kev1n77 merged 4 commits into
GCWing:mainfrom
kev1n77:fmy/ui-main

Conversation

@kev1n77

@kev1n77 kev1n77 commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add ellipsis and interaction-only marquee options to OverflowText, replacing skill-picker-specific overrides.
  • Migrate six session usage tabs to TabGroup.
  • Migrate three appearance market navigation actions to NavigationPanelItem, with static label support.
  • Move market account controls into DialogHeaderActions, separate from the dialog title.
  • Extend Appearance auditing to recognize supported TabGroup attribute forwarding.

Type and Areas

Type: Refactor / UI/UX / Bug fix

Areas: Design system, web UI, FlowChat, appearance settings

Motivation / Impact

These surfaces duplicated behavior already owned by shared components.

Skill labels retain their resting ellipsis without animating solely because an item is virtually selected. Usage tabs use shared keyboard navigation, and market navigation preserves role-based visibility and wrapping labels. Account controls now occupy the dialog header’s action area.

Verification

Implementation verification recorded:

  • pnpm run design-system:check — passed.
  • pnpm run check:web — passed.
  • pnpm run appearance:contract-audit — passed.
  • 105 focused Web UI tests — passed across the three component migrations.
  • Targeted ESLint and stylesheet compilation — passed.
  • pnpm run motion:audit — reviewed; the existing PortForwardDialog reduced-motion warning remains unchanged.

Regression coverage includes overflow behavior, tab selection and keyboard interaction, legacy Appearance selectors, market navigation, and dialog title structure.

Manual visual checks and live remote-scenario verification remain pending.

Reviewer Notes

  • Existing OverflowText and ActionItem defaults remain unchanged.
  • TabGroup’s new tabProps API forwards presentation and product attributes while keeping selection and keyboard behavior component-owned.
  • Persisted Appearance component, part, and state names remain compatible.
  • No transport, filesystem, or remote-routing changes.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@kev1n77
kev1n77 merged commit 531c557 into GCWing:main Sep 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant