Repository navigation
refactor(ui): adopt shared overflow, tabs, and market navigation components - #3013
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Refactor / UI/UX / Bug fix
Areas: Design system, web UI, FlowChat, appearance settings
Motivation / Impact
These surfaces duplicated behavior already owned by shared components.
Skill labels retain their resting ellipsis without animating solely because an item is virtually selected. Usage tabs use shared keyboard navigation, and market navigation preserves role-based visibility and wrapping labels. Account controls now occupy the dialog header’s action area.
Verification
Implementation verification recorded:
pnpm run design-system:check— passed.pnpm run check:web— passed.pnpm run appearance:contract-audit— passed.pnpm run motion:audit— reviewed; the existing PortForwardDialog reduced-motion warning remains unchanged.Regression coverage includes overflow behavior, tab selection and keyboard interaction, legacy Appearance selectors, market navigation, and dialog title structure.
Manual visual checks and live remote-scenario verification remain pending.
Reviewer Notes
tabPropsAPI forwards presentation and product attributes while keeping selection and keyboard behavior component-owned.Checklist