Repository navigation
feat(desktop): improve device previews and GitHub account presentation - #3036
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add left/right device previews to the desktop device status panel. Browsing keeps the active connection unchanged; an explicit button centered over the artwork connects to the selected device.
Slide only the device preview region, keep the connected-client list and footer stable, use circular arrow hover states, and respect reduced-motion preferences.
Place connected clients above the current device, remove their redundant heading, and rename the management action to “Devices & Connections”.
Display the signed-in GitHub avatar and username in account/device settings. Place a numeric connection count next to the connected-devices heading.
Keep the mobile device directory reachable from compact settings after removal of the redundant sidebar add button, preserving access to account sign-out.
Type and Areas
Type: UI/UX, feature, bug fix.
Areas: Desktop Web UI, device status panel, account and connection settings.
Motivation / Impact
Device browsing previously switched the active host immediately and caused the popover layout to jump. Users can now preview online account devices, then explicitly confirm the connection. Account settings now identify the signed-in GitHub user rather than displaying the local device name.
Verification
pnpm --dir src/web-ui exec tsc --noEmit— passed after integrating upstream/main.git diff --check upstream/main...HEAD— passed.Live cross-device connection behavior and final animation were not manually exercised in this verification pass. Existing peer-device switching APIs are reused; remote workspace, mobile/IM remote control, and detached dispatch execution are unchanged.
Focused Vitest run for
AccountPanel.test.tsxandDeviceStatusControl.test.tsx— 2 files, 18 tests passed.Focused ESLint check for
DeviceStatusControl.tsx— passed.pnpm --dir src/mobile-web run test:account-browser— 16 browser tests passed with simulated Relay and isolated Chrome profiles.Mobile TypeScript check — passed.
Reviewer Notes
Changes are split into device-preview and account/connection presentation commits. English, Simplified Chinese, and Traditional Chinese labels are included. No persisted data or wire protocol changes.
Checklist