Skip to content

feat(desktop): improve device previews and GitHub account presentation - #3036

Merged
bobleer merged 6 commits into
GCWing:mainfrom
bobleer:bob/desktop-device-preview
Sep 15, 2026
Merged

bobleer merged 6 commits into
GCWing:mainfrom
bobleer:bob/desktop-device-preview

Conversation

@bobleer

@bobleer bobleer commented Sep 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add left/right device previews to the desktop device status panel. Browsing keeps the active connection unchanged; an explicit button centered over the artwork connects to the selected device.

  • Slide only the device preview region, keep the connected-client list and footer stable, use circular arrow hover states, and respect reduced-motion preferences.

  • Place connected clients above the current device, remove their redundant heading, and rename the management action to “Devices & Connections”.

  • Display the signed-in GitHub avatar and username in account/device settings. Place a numeric connection count next to the connected-devices heading.

  • Keep the mobile device directory reachable from compact settings after removal of the redundant sidebar add button, preserving access to account sign-out.

Type and Areas

Type: UI/UX, feature, bug fix.
Areas: Desktop Web UI, device status panel, account and connection settings.

Motivation / Impact

Device browsing previously switched the active host immediately and caused the popover layout to jump. Users can now preview online account devices, then explicitly confirm the connection. Account settings now identify the signed-in GitHub user rather than displaying the local device name.

Verification

  • pnpm --dir src/web-ui exec tsc --noEmit — passed after integrating upstream/main.

  • git diff --check upstream/main...HEAD — passed.

  • Live cross-device connection behavior and final animation were not manually exercised in this verification pass. Existing peer-device switching APIs are reused; remote workspace, mobile/IM remote control, and detached dispatch execution are unchanged.

  • Focused Vitest run for AccountPanel.test.tsx and DeviceStatusControl.test.tsx — 2 files, 18 tests passed.

  • Focused ESLint check for DeviceStatusControl.tsx — passed.

  • pnpm --dir src/mobile-web run test:account-browser — 16 browser tests passed with simulated Relay and isolated Chrome profiles.

  • Mobile TypeScript check — passed.

Reviewer Notes

Changes are split into device-preview and account/connection presentation commits. English, Simplified Chinese, and Traditional Chinese labels are included. No persisted data or wire protocol changes.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@bobleer
bobleer merged commit 327e0af into GCWing:main Sep 15, 2026
9 checks passed
@bobleer
bobleer deleted the bob/desktop-device-preview branch September 24, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant