Skip to content

refactor(ui): adopt shared components across installer and standalone markets - #3038

Merged
kev1n77 merged 6 commits into
GCWing:mainfrom
kev1n77:fmy/ui-main
Sep 15, 2026
Merged

kev1n77 merged 6 commits into
GCWing:mainfrom
kev1n77:fmy/ui-main

Conversation

@kev1n77

@kev1n77 kev1n77 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adopt shared Input, Textarea, Button, and IconButton components across the installer, MiniApp marketplace, and Skin marketplace.
  • Connect installer options to Checkbox and replace model configuration dropdowns with Select.
  • Initialize installer theme and typography before rendering.
  • Use native Disclosure for Skin release history and review manifests.
  • Update marketplace Docker build dependencies, setup documentation, and page interaction tests.

Type and Areas

Type: Refactor / UI/UX / regression fix / test

Areas: Installer, MiniApp marketplace web, Skin marketplace web, design system integration, Docker builds, docs.

Motivation / Impact

Replace duplicated controls in actual product pages with shared components while preserving existing workflows and surface layouts.

The migration retains native form field names, validation, file uploads, submission restrictions, and moderation permissions. Installer checkboxes use native input semantics, and model selectors support shared popup behavior and focus restoration. Remote model loading keeps the selector open while options arrive.

Verification

The following checks passed for the initial component migration:

  • pnpm --dir OpenBitFun-Installer run type-check
  • pnpm --dir OpenBitFun-Installer run test
  • pnpm --dir OpenBitFun-Installer run build
  • pnpm --dir src/miniapp-market-web run type-check
  • pnpm --dir src/miniapp-market-web run test
  • pnpm --dir src/miniapp-market-web run build
  • pnpm --dir src/skin-market-web run type-check
  • pnpm --dir src/skin-market-web run test
  • pnpm --dir src/skin-market-web run build
  • pnpm run design-system:check
  • pnpm run theme:color-audit:all
  • pnpm install --frozen-lockfile --ignore-scripts --offline

The initial page suites passed 50 tests. The subsequent installer Select and bootstrap fix adds three model configuration tests; final-HEAD verification for that follow-up has not been confirmed in this PR draft.

Docker builds were not exercised because Docker was unavailable. Manual visual acceptance, real installation/uninstallation, and remote scenario testing remain outstanding.

Reviewer Notes

  • Check light/dark themes, Chinese/English labels, narrow layouts, and keyboard focus.
  • Pay particular attention to installer theme cards, model selector popups, market textarea widths, and icon/text alignment.
  • MiniApp web submission controls remain gated by server configuration.
  • Skin moderation controls require an administrator account; older-release disclosure appears when a listing has more than four releases.
  • Native file inputs and marketplace native selects are retained.
  • No backend API, persisted data format, or deployment changes are included.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@kev1n77
kev1n77 merged commit 936b2c9 into GCWing:main Sep 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant