Skip to content

fix(desktop): align macOS window controls with toolbar - #3041

Merged
wgqqqqq merged 1 commit into
GCWing:mainfrom
wgqqqqq:wgq/fix-macos-titlebar-alignment
Sep 15, 2026
Merged

wgqqqqq merged 1 commit into
GCWing:mainfrom
wgqqqqq:wgq/fix-macos-titlebar-alignment

Conversation

@wgqqqqq

@wgqqqqq wgqqqqq commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Align macOS native window controls with the 45px navigation toolbar. Configure the traffic-light inset through WindowConfig so both Tao and Wry receive it, and adjust the inset to place the native button center at 22.5pt.

Type and Areas

Type: Bug fix / UI

Areas: Desktop / Tauri (macOS)

Motivation / Impact

The native close, minimize, and zoom buttons appeared above the sidebar and history controls. The WebviewWindowBuilder setter configured only Wry, leaving Tao without the inset needed when native window lifecycle events reapply button placement. Creating the macOS window from the shared configuration supplies the inset to both layers.

Verification

  • pnpm run fmt:rs and git diff --check: passed.
  • pnpm run desktop:dev: final Rust build completed and the development window loaded successfully.
  • Temporary in-process AppKit diagnostics measured the native close-button center at 22.5pt from the window top, including a check five seconds after page load. Diagnostics were removed from the final change.
  • Opened an isolated real desktop instance and exercised sidebar expand/collapse. Automated screenshots had a system sharing indicator covering the native controls, so full visual confirmation was limited.
  • Full desktop tests were not completed; the earlier run was stopped during dependency compilation.
  • Exercised local macOS only. Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised.

Reviewer Notes

Only macOS window construction changes. No persisted settings, wire contracts, user-facing strings, or new commands are introduced.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable (not applicable).

@wgqqqqq
wgqqqqq merged commit c46fb17 into GCWing:main Sep 15, 2026
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant