Repository navigation
fix(desktop): align macOS window controls with toolbar - #3041
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align macOS native window controls with the 45px navigation toolbar. Configure the traffic-light inset through
WindowConfigso both Tao and Wry receive it, and adjust the inset to place the native button center at 22.5pt.Type and Areas
Type: Bug fix / UI
Areas: Desktop / Tauri (macOS)
Motivation / Impact
The native close, minimize, and zoom buttons appeared above the sidebar and history controls. The WebviewWindowBuilder setter configured only Wry, leaving Tao without the inset needed when native window lifecycle events reapply button placement. Creating the macOS window from the shared configuration supplies the inset to both layers.
Verification
pnpm run fmt:rsandgit diff --check: passed.pnpm run desktop:dev: final Rust build completed and the development window loaded successfully.Reviewer Notes
Only macOS window construction changes. No persisted settings, wire contracts, user-facing strings, or new commands are introduced.
Checklist