Require published latest-v1.json to declare the macOS installers - #3119
Merged
bobleer merged 1 commit intoSep 18, 2026
Merged
Conversation
The pre-upload verifier already demands darwin-aarch64 and darwin-x86_64 manual installers next to Windows. The post-publish readback still only asked for Windows, so a release could lose the .dmg entries between staging and GitHub Latest and still go green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pre-upload verifier already requires
manual_installersforwindows-x86_64,darwin-aarch64, anddarwin-x86_64. The post-publish readback oflatest-v1.jsonstill only required Windows, so a release could drop the.dmgentries between staging and GitHub Latest and still pass.Align the published check with the pre-upload check, and lock both in
check-github-config.Test plan
pnpm run check:github-config(27 pass)