Repository navigation
fix(desktop): stabilize window geometry, command output copy, and code rendering - #3142
Merged
Merged
Conversation
Copy all output available to the command card regardless of terminal scroll position or line wrapping. Remove the viewport-based copy dependency and cover completed, running, and cancelled output across ExecCommand, WriteStdin, and ExecControl.
Prevent taskbar minimization from shrinking the main Windows WebView and reflowing the page into a tiny viewport before restoration. Let the desktop host synchronize valid, non-minimized window bounds instead of using Tauri's multi-WebView autoresizer for the main view. Keep embedded browser layout ownership unchanged and document focused verification for the new geometry guard. Validation: Rust test compilation passed; the focused regression test passed with the desktop manifest embedded in a temporary test copy. The user confirmed that taskbar restoration no longer flickers.
Wait for the Prism AST engine before replacing the fallback to avoid an intermediate line-number layout shifting code on first session open. Match fallback text and line-number colors to the Prism theme and keep line numbers italic throughout the transition. Add coverage for engine readiness and concurrent loader requests.
wsp1911
changed the title
Remove unnecessary mutable overlay cleanup bindings and move shared hooks and helpers out of component modules so ESLint can enforce the intended boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three user-facing regressions:
Type and Areas
Type: Bug fix / regression fix / UI/UX
Areas: Desktop/Tauri, Web UI, Markdown rendering, terminal tool cards
Motivation / Impact
ExecCommand,WriteStdin, andExecControloutput is complete for completed, running, and cancelled states.Verification
cargo test -p openbitfun-desktop --no-default-features --lib window_webview_geometry::testspassed according to the desktop commit.Reviewer Notes
The desktop change disables autoresizing only for the main WebView on Windows; embedded browser WebViews retain their existing layout ownership. The geometry guard ignores minimized or invalid bounds and synchronizes valid restored sizes.
Checklist