Skip to content

chore(web-ui): hide appearance package import and Skin market entries #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kev1n77 merged 1 commit into from
Sep 20, 2026
Merged

chore(web-ui): hide appearance package import and Skin market entries #3146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/web-ui/src/infrastructure/config/components/AppearancePackageConfigSection.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,21 +91,27 @@ describe('AppearancePackageConfigSection', () => {
expect(html).toContain('data-testid="appearance-builtin-theme-select"');
expect(html.match(/data-testid="appearance-builtin-theme-option"/g)).toHaveLength(3);
expect(html.match(/class="appearance-package-config__selected-mark"/g)).toHaveLength(1);
expect(html).toContain('package.market.open');
expect(html).toContain('package.import');
expect(html).toContain('aria-label="package.export"');
expect(html).toContain('aria-label="package.delete"');
expect(html).toContain('accept=".openbitfun-appearance,.zip,application/zip"');
expect(html).toContain('data-openbitfun-part="packageSection"');
expect(html).toContain('data-openbitfun-part="packageActions"');
expect(html).toContain('data-openbitfun-component="button"');
expect(html.match(/data-openbitfun-variant="outline"/g)).toHaveLength(2);
expect(html).not.toContain('data-size="md"');
expect(html).toContain('data-openbitfun-component="icon-button"');
expect(html).toContain('openbitfun-config-page-section');
expect(html).not.toContain('appearance-package-config__action-button');
expect(html).not.toContain('.openbitfun-skin');
});

it('hides the Skin market and appearance package import entry points', () => {
const html = renderToStaticMarkup(<AppearancePackageConfigSection />);

expect(html).not.toContain('package.market.open');
expect(html).not.toContain('package.import');
expect(html).not.toContain('accept=".openbitfun-appearance,.zip,application/zip"');
expect(html).not.toContain('appearance-package-config__file-input');
expect(html).toContain('aria-label="package.export"');
expect(html).toContain('aria-label="package.delete"');
});

it('uses high-density artwork and a separate selection mark for the built-in package card', () => {
appearanceStateMock.selectedAppearanceId = 'system';

Expand Down
75 changes: 46 additions & 29 deletions src/web-ui/src/infrastructure/config/components/AppearancePackageConfigSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ import {
} from '@/infrastructure/appearance';
import { notificationService } from '@/shared/notification-system';
import { AppearanceMarketDialog } from './AppearanceMarketDialog';
import {
APPEARANCE_MARKET_ENTRY_VISIBLE,
APPEARANCE_PACKAGE_IMPORT_VISIBLE,
} from './appearancePackageEntryVisibility';
import { ConfigPageSection, formatStandaloneUiText } from './common';

const DEFAULT_APPEARANCE_PREVIEW_SRC = '/assets/appearance/openbitfun-default-preview@4x.png';
Expand Down Expand Up @@ -318,6 +322,9 @@ export function AppearancePackageConfigSection() {
], [builtinAppearances, t, tApplication]);
const selectedBuiltinThemeId = defaultPackageSelected ? selectedAppearanceId : '';
const busy = loading || !initialized || status === 'applying';
const hasPackageActions = APPEARANCE_MARKET_ENTRY_VISIBLE
|| APPEARANCE_PACKAGE_IMPORT_VISIBLE
|| Boolean(selectedAppearance);

const handleAppearanceSelection = async (id: string) => {
if (busy || id === selectedAppearanceId) return;
Expand Down Expand Up @@ -405,28 +412,32 @@ export function AppearancePackageConfigSection() {
description={t('package.description')}
bodySurface={false}
fieldSurface="ambient"
extra={(
extra={hasPackageActions ? (
<div
className="appearance-package-config__actions"
data-openbitfun-component="appearance-settings"
data-openbitfun-part="packageActions"
>
<Button
variant="outline"
size="sm"
disabled={busy}
onClick={() => setMarketOpen(true)}
>
{t('package.market.open')}
</Button>
<Button
variant="outline"
size="sm"
disabled={busy}
onClick={() => inputRef.current?.click()}
>
{t('package.import')}
</Button>
{APPEARANCE_MARKET_ENTRY_VISIBLE && (
<Button
variant="outline"
size="sm"
disabled={busy}
onClick={() => setMarketOpen(true)}
>
{t('package.market.open')}
</Button>
)}
{APPEARANCE_PACKAGE_IMPORT_VISIBLE && (
<Button
variant="outline"
size="sm"
disabled={busy}
onClick={() => inputRef.current?.click()}
>
{t('package.import')}
</Button>
)}
{selectedAppearance && (
<>
<IconButton
Expand All @@ -448,19 +459,21 @@ export function AppearancePackageConfigSection() {
</>
)}
</div>
)}
) : undefined}
data-openbitfun-component="appearance-settings"
data-openbitfun-part="packageSection"
data-openbitfun-package-type={selectedAppearance ? 'imported' : 'native'}
data-openbitfun-state={busy ? 'disabled' : undefined}
>
<input
ref={inputRef}
className="appearance-package-config__file-input"
type="file"
accept=".openbitfun-appearance,.zip,application/zip"
onChange={handleImport}
/>
{APPEARANCE_PACKAGE_IMPORT_VISIBLE && (
<input
ref={inputRef}
className="appearance-package-config__file-input"
type="file"
accept=".openbitfun-appearance,.zip,application/zip"
onChange={handleImport}
/>
)}
<div className="appearance-package-config__gallery">
<AppearancePackagePreview
appearanceId={SYSTEM_APPEARANCE_ID}
Expand Down Expand Up @@ -504,7 +517,9 @@ export function AppearancePackageConfigSection() {
/>
))}
</div>
<AppearanceMarketDialog isOpen={marketOpen} onClose={() => setMarketOpen(false)} />
{APPEARANCE_MARKET_ENTRY_VISIBLE && (
<AppearanceMarketDialog isOpen={marketOpen} onClose={() => setMarketOpen(false)} />
)}
{failure && (
<AppearancePackageFailurePanel failure={failure} onDismiss={() => setFailure(null)} />
)}
Expand All @@ -516,9 +531,11 @@ export function AppearancePackageConfigSection() {
>
<AlertTriangle size={16} aria-hidden="true" />
<span>{t('package.missingSelection', { id: unavailableSelectionId })}</span>
<Button variant="primary" size="md" onClick={() => setMarketOpen(true)}>
{t('package.market.open')}
</Button>
{APPEARANCE_MARKET_ENTRY_VISIBLE && (
<Button variant="primary" size="md" onClick={() => setMarketOpen(true)}>
{t('package.market.open')}
</Button>
)}
</div>
)}
</ConfigPageSection>
Expand Down
10 changes: 10 additions & 0 deletions src/web-ui/src/infrastructure/config/components/appearancePackageEntryVisibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/**
* Visibility switches for the Appearance package distribution entry points.
*
* The Skin market and the local package import path are hidden from the
* Appearance settings page. The market dialog, the market API, and the backend
* commands stay wired behind these switches, so restoring an entry point only
* requires flipping its switch back to true.
*/
export const APPEARANCE_MARKET_ENTRY_VISIBLE: boolean = false;
export const APPEARANCE_PACKAGE_IMPORT_VISIBLE: boolean = false;
35 changes: 11 additions & 24 deletions tests/e2e/specs/l0-appearance.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,36 +843,23 @@ describe('L0 Appearance', () => {
expect(await picker.isDisplayed()).toBe(true);
});

it('should preserve design-system inline spacing on Appearance action buttons', async () => {
it('should keep the Skin market and appearance package import entry points hidden', async () => {
await openAppearanceSettings();
await waitForDisplayed('[data-openbitfun-part="packageActions"] [data-openbitfun-component="button"]');
await waitForDisplayed('[data-openbitfun-part="packageSection"]');

const buttonSpacing = await browser.execute(() => {
return Array.from(document.querySelectorAll<HTMLElement>(
const packageEntryPoints = await browser.execute(() => ({
actionButtons: Array.from(document.querySelectorAll<HTMLElement>(
'[data-openbitfun-part="packageActions"] [data-openbitfun-component="button"]',
)).map((button) => {
const styles = window.getComputedStyle(button);
)).map(button => button.textContent?.trim() ?? ''),
fileInputs: document.querySelectorAll('.appearance-package-config__file-input').length,
}));

return {
text: button.textContent?.trim() ?? '',
paddingLeft: styles.paddingLeft,
paddingRight: styles.paddingRight,
paddingToken: styles.getPropertyValue('--_button-padding-inline').trim(),
width: button.getBoundingClientRect().width,
};
});
});
expect(packageEntryPoints.actionButtons).toEqual([]);
expect(packageEntryPoints.fileInputs).toBe(0);

console.log('[L0] Appearance action button spacing:', JSON.stringify(buttonSpacing, null, 2));
expect(buttonSpacing).toHaveLength(2);
for (const button of buttonSpacing) {
expect(button.paddingLeft).toBe('20px');
expect(button.paddingRight).toBe('20px');
expect(button.paddingToken).toBe('20px');
}
await saveElementScreenshot(
'[data-openbitfun-part="packageActions"]',
'l0-appearance-button-inline-spacing',
'[data-openbitfun-part="packageSection"]',
'l0-appearance-package-entry-points-hidden',
);
});

Expand Down
Loading