Repository navigation
fix(web-ui): show the scheduled job mark on session rows only - #3171
Merged
Merged
Conversation
The scheduled-job count shipped as a pill beside the title, on session rows and workspace rows alike. On a session row it read as a fifth activity badge next to the BTW, dispatch, review, and background-subagent chips, and it drew its clock at 8px, where the shared 1.6 stroke width resolves to about half a pixel, so the glyph became a smudge beside the count. A workspace owns no session, so the count it borrowed from its sessions did not belong on that row at all. Draw the mark as one 12px secondary clock in the session row's trailing cell, the same drawing and slot the session status indicator already uses, and keep the count on the accessible name. A session with a status to report keeps that status, and the cell still yields to the row menu on hover or focus. Workspace rows stop subscribing to the counts store, and the badge stylesheet rule goes with it. Co-authored-by: bitfun-ai <318544290+bitfun-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled-job count shipped as a chip beside the title on both the session row and the workspace row. On a session row it read as a fifth activity badge next to the BTW, dispatch, review, and background-subagent chips, and it drew its clock at 8px, where the shared
1.6stroke width resolves to about half a pixel, so the glyph became a smudge next to the count. A workspace owns no session, so the count it borrowed from its sessions did not belong on that row at all.Type and Areas
Type: UI/UX fix
Areas: web UI (NavPanel session and workspace rows)
Motivation / Impact
The mark now reads as one mark on one row:
clockin the trailing cell, the same drawing and slotSessionStatusIndicatoralready uses. The count stays on the accessible name instead of a visible digit, so the mark is scannable without competing with the title.SessionStatusIndicatortakes anidleFallback: the cell shows the status when the session has one to report (running, approval, unread, queued, and so on) and the scheduled mark otherwise, still yielding to the row menu on hover or focus. No new stylesheet rule is needed for it.cronJobCountsStore, so the counts store no longer needs to be mounted from that row.SessionsSection.scssreturns to its pre-fix(scheduled-jobs): surface agent-created jobs in the product surfaces #3149 state: theinline-item-cron-badgerule is gone, verified by the file's blob hash (7e13a7a9f) matching theindex 7e13a7a9f..e02b4a607line of fix(scheduled-jobs): surface agent-created jobs in the product surfaces #3149.Verification
The two layout contract tests move with the change: the session row test asserts the stylesheet no longer carries any
cronrule, that the mark goes throughidleFallback, and that it stays atxswithsecondarytone; the workspace row test inverts into an assertion that the row must not referencescheduledJobCount,cronJobCountsStore,badgeTooltip, orinline-item-cron.Reviewer Notes
queuedstatus mark are now the same glyph in the same cell, so a clock on a session row's right edge can mean either "this session has scheduled jobs" or "this session is queued". Differentiating them would take a different glyph, which would give up the point of drawing them alike. Happy to change it if the duplication is not wanted.cronJobCountsStore'sbyWorkspaceIdis now referenced only by the store's own test. It is left in place in this PR so the snapshot shape stays stable; say the word and I will strip it in a follow-up or here.nav.scheduledJobs.badgeTooltipnow serves as the accessible name.