fix(review): correct controls, approval inheritance, and error feedback - #3172
Merged
Merged
Conversation
Stop select-all checkbox clicks from toggling the remediation list. Cover selection and title clicks with the real checkbox in expanded and collapsed states.
Show copy and save controls while a review is running. Disable report actions until report data arrives, then enable the existing export flow.
Refresh review session permission settings from the parent before each submission and after backend session recreation. Clear inherited overrides when the parent returns to its default and retain surface ownership checks.
Allow the search action group to shrink with the session panel and replace the narrow-window minimum width with a preferred width. Preserve the existing scene chrome and search result layout.
Show localized summaries for review action failures while retaining complete diagnostic text and structured launch error reasons. Preserve raw failure metadata in notifications and keep error details separate from the compact status header.
Classify a missing Git executable separately from invalid workspace paths. Expose stable failure codes and translate review panel errors while retaining the existing repository trust recovery flow.
guantw
force-pushed
the
fix/review-shared-behavior
branch
from
September 21, 2026 09:45
a1babc5 to
ec89f7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix review controls, permission inheritance, and failure presentation:
Type and Areas
Bug fix: Web UI, desktop/Tauri, and review-platform services.
Verification
cargo test --locked -p openbitfun-services-integrations --no-default-features --features review-platform --lib review_platform: 128 passed; 2 external-network smoke tests ignored by default.cargo test --locked -p openbitfun-desktop --lib --no-run --message-format=json: passed. Theapi::review_platform_api::tests::filter passed all 4 tests on a temporary executable copy with the existing desktop manifest embedded using Windows SDKmt.exe, as documented in the desktop guide.pnpm run check:web,pnpm run i18n:audit,pnpm run check:build-prereqs, andgit diff --check: passed.Validation was local on Windows. Live remote-workspace, remote-control, Peer Device, and Detached Dispatch scenarios were not exercised; transport wrappers and remote permission routing were covered with test fixtures. No installer or live UI validation was performed.
Checklist