fix(flowchat): prevent pet session history from loading indefinitely - #3207
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix pet bubble navigation leaving an uncached historical session permanently loading. Programmatic opens restore history before selecting the session, but the active-only hydration guard discarded the returned records while the session was still inactive. Allow these restores to commit before activation and upgrade any weaker in-flight preload.
Type and Areas
Type: Bug fix
Areas: Web UI, desktop pet session navigation, historical session hydration
Motivation / Impact
Clicking a pet bubble for an inactive, uncached local session could select a metadata-only session after its history request had already settled, with no remaining request to populate the chat. The session now receives its restored messages before selection. Existing activate-first navigation retains its active-only hydration guard.
Verification
metadata-only; the fix passes both direct-open and concurrent-preload cases.pnpm run check:webandgit diff --check.Reviewer Notes
AI-assisted implementation and review. Validation consists of automated tests and frontend checks; desktop and remote manual validation remains outstanding. No persisted schema, protocol, user-facing copy, or styling changes.
Checklist