Repository navigation
fix(mobile-web): contain suggestions and widen message sheets - #3455
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix mobile-web input suggestions overflowing their pill and edit/rollback message fields shrinking inside confirmation sheets. Long suggestions now ellipsize while keeping the acceptance icon visible; editing and rollback previews fill the available sheet width with leading-aligned text.
Type and Areas
Bug fix / UI regression; mobile web and focused browser CI.
Motivation / Impact
MobileButtonlabels usedisplay: contents, which prevented the suggestion's overflow rules from applying to a layout box. Confirmation sheets center their children, so the message container also needed an explicit full width and text alignment. Both fixes use existing component hooks and styles.Verification
pnpm --dir src/mobile-web run test:prompt-suggestion-browserpnpm --dir src/mobile-web run test:rollback-browserpnpm --dir src/mobile-web run type-checkpnpm run build:mobile-webpnpm run theme:color-audit:allpnpm run check:github-config,pnpm run check:repo-hygiene, andgit diff --checkThe Chrome fixtures exercise the production composer, chat page, stream projection and sheets at 320/390/768/1200px. They cover original-text acceptance, focus, compact/wide resizing, long Chinese text and URLs, light/dark sheets, a reduced-height viewport, scrolling, editing and cancellation without rollback or send calls. CI now runs both layout suites and publishes synthetic screenshots in the
mobile-input-layout-screenshotsartifact.Reviewer Notes
CI screenshots: mobile-input-layout-screenshots (synthetic content; retained for 7 days).
AI-assisted; focused browser verification and production build completed. Remote-control host IO is simulated. Android, iOS and HarmonyOS received source-level layout review only; native devices and live remote workspace/control/peer/dispatch scenarios were not exercised.
Checklist