fix(filter.numeric_filter): Prefer filter.type in the spread operation#2900
Merged
Conversation
AlexanderGeere
marked this pull request as ready for review
July 16, 2026 14:09
AlexanderGeere
requested review from
RobAndrewHurst,
cityremade,
dbauszus-glx and
simon-leech
July 16, 2026 14:09
simon-leech
approved these changes
Jul 16, 2026
simon-leech
left a comment
Contributor
There was a problem hiding this comment.
Working for me - tested overwriting the title and type of filter and all good! 👍
{
"title": "UK Rank",
"field": "rp_rank",
"fieldfx": "select case when rp_rank is not null then to_char(rp_rank, 'FM999,999,999') || ' of ' || 1000 else null end",
"inline": true,
"skipNullValue": true,
"filter": {
"title": "HELLO",
"type": "integer"
}
},
dbauszus-glx
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Filter types were being overwritten by the type of the entry due to this line:
in lib/ui/layers/filters.mjs. This meant that setting the filter type to numeric or integer would always use numeric steps e.g. 0.01

as the type of the filter would the same as the entry, text for example, and steps would default:
This PR uses a spread operation filter to entry to maintain the filters' type.
GitHub Issue
#2895
Type of Change
How have you tested this?
Tested locally
Important
bugs_testing/filter/all_filters.jsonThe numeric filter should use decimal steps and the integer filter should use integer steps
Testing Checklist
Code Quality Checklist