Skip to content

Add Abstract Factory Design Pattern project#15

Open
Harshad046 wants to merge 6 commits into
GET-SDE-READY:mainfrom
Harshad046:main
Open

Add Abstract Factory Design Pattern project#15
Harshad046 wants to merge 6 commits into
GET-SDE-READY:mainfrom
Harshad046:main

Conversation

@Harshad046

Copy link
Copy Markdown

Hi Vinamer, I've done the code for Abstract Factory Design Pattern, pls review the code and let me know changes if any.

@Harshad046

Copy link
Copy Markdown
Author

Hi, I've also added the code Singleton Pattern.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not .idea folder to commits

L1 = new ArrayList<>();
}

public static synchronized Logger getInstance() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the basic implementation, please add with double checking and the Bill Pugh method as well

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more classes in the factory.
Adding just one class for each is not good enough

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not commit this file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not commit any xml file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a simple factory not abstract factory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants