Revision DesInventar metadata description and proposal loss group#123
Revision DesInventar metadata description and proposal loss group#123bennyistanto wants to merge 4 commits into
Conversation
4ac1aa0 to
f2109d8
Compare
📊 PR Sync Results📝 Dataset Changes
🧮 Vectors
✅ Validation
🧪 Search Tests
❌ Failed: "vulnerability flood"Description: Test adapted from comments on Issue #31 Expected includes:
Missing includes: Top 5 actual results:
|
|
@matamadio Thanks for the reminder during the recent call. I apologize, I don't know if the rdl-02.yml and rdl-03.yml are the schema in JKAN. As we will not touch the schema, I revised the approach for visualising the Loss group, and only dealing with html and css (edit and add new file). So far looks great. See below and looking forward to receive your feedback.
Compare to Loss dataset with
|
|
I like the grouping approach 👍 |
lydiascarf
left a comment
There was a problem hiding this comment.
@bennyistanto this looks good to me, except for two things:
- when i rebase with
git rebase -i origin/rdl-0.3, i realize this PR is reviving the main.css file we deleted for the redesign. if i then, delete the file it mostly looks good, but the collapsible loss group sections are no longer correctly styled. could you please take a look at what happened there? i can help, but i have a lot to do with the urban data tracker ASAP, so i'll wait for you to let me know if you need help - after rebasing, can you please run the Python script again with
python3 main.py --markdownbecause i'm seeing changes after rebasing that won't be triggered by CI
We merged main.css into https://github.com/GFDRR/rdl-jkan/blob/rdl-0.3/css/modern-theme.css, it should be sufficient to paste new styling there. |
@lydiascarf I have deleted the main.css, and run |
This PR contains: - Revision of DesInventar markdown's dataset long description in single paragraphs, which replace into shorter description and grouping based on `hazard_type` - Proposal for improving (individual) metadata page which describe in #115
926b1a5 to
07ea61d
Compare
lydiascarf
left a comment
There was a problem hiding this comment.
just rebased to address conflicts that have cropped up in the last couple months!
| processes: tornado | ||
| seasonality: '' | ||
| license: CC-BY-IGO-3.0 | ||
| license: Creative Commons Attribution for Intergovernmental Organisations (CC BY-IGO) |
There was a problem hiding this comment.
the other datasets have licenses in the code form. the full license names live in _data/rdl-license-name.yml
There was a problem hiding this comment.
From the filename, seems this dataset came from first iteration when I worked on hdx, after that so many change in the schema and the HDX pipeline too.
| descriptions: | ||
| - 'Loss data from HDX dataset: Burkina Faso - Internal Displacements Updates (IDU) | ||
| (event data)' | ||
| hazard_type: flood |
There was a problem hiding this comment.
how should loss_count and loss_groups render? i want to add this to the schema and the UI templates
|
@matamadio what is the best way to handle many errors due to very old version metadata. I dont think its a good idea for @lydiascarf to fix this various problem in v0.3 json datasets. How about I share some of the example JSON v1.0 from various project/case, so Lydia can directly working using correct metadata for |
Agree, let's focus on 1.0 release which will replace most/all previous datasets. |


This PR contains:
hazard_type