Fix four review issues from PR #59 folder-context-menu feature

[Copilot]

PR #59 added a "New Connection" folder context menu entry that pre-selects the clicked folder in the connection dialog. The code review identified four correctness issues that this PR addresses.

Fixes

• connection-manager.tsx — "New Connection" menu item was always rendered even when onNewConnection is absent, producing a silent no-op click. Now conditionally rendered only when the prop is provided. Also updated prop type to (folderPath?: string) => void.

• App.tsx — handleNewTab(folderPath?) was passed directly as a Radix/DOM onClick handler in some callsites, meaning it would receive a MouseEvent and store it as a folder path. Added a typeof folderPath === 'string' guard:

  const handleNewTab = useCallback((folderPath?: string) => {
    setConnectionInitialFolder(typeof folderPath === 'string' ? folderPath : undefined);
    ...
  }, []);

• connection-dialog.tsx — Folder pre-selection was inlined inside the main open/editingConnection effect and initialFolder was added to its dep array, causing the full reset/reload to re-run on every initialFolder change (wiping in-progress edits). Moved pre-selection into a dedicated effect with its own dep array:

  useEffect(() => {
    if (open && !editingConnection && initialFolder) {
      setConnectionFolder(initialFolder);
    }
  }, [open, editingConnection, initialFolder]);

• connection-dialog-folder.test.tsx — Test used React.ComponentProps without importing the React namespace. Switched to import { type ComponentProps } from 'react'.

[GOODBOY008]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts with origin/main. All four conflicting files have been handled:

• src/App.tsx — kept our typeof folderPath === 'string' guard
• src/__tests__/connection-dialog-folder.test.tsx — kept our proper ComponentProps import
• src/components/connection-dialog.tsx — kept main's displayValues/handleNumberInput from PR fix(connection-dialog): prevent number input default value override on clear #62, re-applied our dedicated initialFolder effect fix
• src/components/connection-manager.tsx — kept main's mergeExpanded from PR fix(sidebar): fix folder click not selecting and right-click expanding unrelated nodes #61, re-applied our conditional onNewConnection rendering and aria-label fixes

All 508 tests pass.