fix(edit-connection): improve tab sync, credential handling, and save flow - #67
Merged
GOODBOY008 merged 2 commits intoJul 30, 2026
Merged
Conversation
… flow - Add UPDATE_TAB_NAME reducer for live tab title updates after rename - Add handleSave for edit mode so Save button doesn't trigger reconnect - Track pendingConnectionId to auto-retry connection after saving a fix - Reuse existing failed tab on auto-retry instead of creating a duplicate - Fix 6 setEditingConnection calls missing credential fields - Save SSH config before connecting (aligns with SFTP/FTP/Desktop) - Use unique session IDs to prevent stale backend session interference - Add refreshTrigger to ConnectionManager for immediate sidebar refresh - Remove connectionName from PtyTerminal effect deps to prevent reconnect on rename Test: 510 tests pass, 37 test files
The sed command used to add the save button key accidentally created an extra transferQueue.save entry not present in en.json. Test: i18n parity check passes, 947 keys in both files
GOODBOY008
force-pushed
the
fix/edit-connection-tab-sync
branch
from
July 29, 2026 09:34
f285c93 to
28fbca2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the edit-connection experience: tab titles now update after a rename, credentials are preserved when the edit dialog opens from a failed connection, and the "Update & Connect" button becomes "Save" to avoid unnecessary reconnection.
Changes
Edit-connection flow
UPDATE_TAB_NAMEreducer action — tab title updates live after saving a renamed connectionhandleSavereplaceshandleConnectin edit mode — the button now says "Save" and doesn't trigger a reconnectpendingConnectionIdtracking — when the edit dialog was opened from a failed double-click (e.g. wrong port), saving the fix auto-retries the connectionsetEditingConnectioncalls now include credentials —password,privateKeyPath, andpassphraseare no longer lost when a connection error opens the edit dialogNew-connection / general
ConnectionManagernow refreshes its tree when the dialog closes, so saved changes appear immediatelyStability
PtyTerminaleffect no longer depends onconnectionName— renaming a connection no longer tears down the WebSocket + PTY sessionUPDATE_TAB_NAME+RECONNECT_TABreducer tests addedTesting