Local dev: allow http OIDC authority + local compose - #297
Open
xiduzo wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
felixcicatt
reviewed
Aug 11, 2026
| options.Authority = authOptions.Authority; | ||
| // Local/dev only: allow an http OIDC authority (e.g. a local Keycloak). | ||
| // Defaults to requiring HTTPS; set OIDC_REQUIRE_HTTPS=false to relax. | ||
| options.RequireHttpsMetadata = |
Collaborator
There was a problem hiding this comment.
I'd rather follow the approach we use for the other properties: get the value from configuration in Program.cs, pass it on here. We do the same in PABC:
https://github.com/Platform-Autorisatie-Beheer-Component/PABC-API/blob/08bd25888f7256175ad19fd1111137a0687e49ff/PABC.Server/Program.cs#L52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds local-development support so the ODPC server can boot and be exercised outside a fully-provisioned OIDC environment.
ODPC.Server/Authentication/AuthenticationExtensions.cs— newOIDC_REQUIRE_HTTPSenv toggle. Defaults to requiring HTTPS metadata (unchanged production behaviour); setOIDC_REQUIRE_HTTPS=falseto allow anhttp://OIDC authority.docker-compose.local.yml(new) — placeholderOIDC_*values so the server starts and serves the SPA.Why
The demo compose expects a real OpenID Connect IdP (via user-secrets / Azure AD), so the server would not boot locally. During the integrated-stack / E2E work we run against a local Keycloak on plain
http://, which the OIDC middleware rejects by default (RequireHttpsMetadata=true). The env toggle lets local/CI point at a local Keycloak without weakening the production default; the compose override supplies bootable placeholder config.🤖 Generated with Claude Code