feat: Playwright E2E auth tests, Grafana datasource fix, pre-launch checklist#70
Conversation
…ch checklist - Add Playwright smoke tests covering auth guard redirects and form rendering; wired into web CI with placeholder Firebase env vars - Fix Grafana datasource UID so provisioned dashboard panels resolve - Rename datasources/prometheus.yml → datasources.yml to prevent VS Code YAML extension from applying the wrong Prometheus scrape-config schema - Add pre-launch checklist section to RUNBOOK.md
|
Warning Review limit reached
More reviews will be available in 54 minutes and 40 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds Playwright end-to-end testing for the web app, wires those tests into the web CI workflow, adds a pre-launch checklist to RUNBOOK.md, and sets an explicit UID for the Grafana Prometheus datasource. ChangesWeb Playwright E2E
Runbook pre-launch checklist
Grafana Prometheus UID
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Vitest was picking up the Playwright spec file and failing because @playwright/test's test.describe() is not compatible with Vitest.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/e2e/auth.spec.ts`:
- Around line 1-3: The Playwright spec is being picked up by Vitest discovery,
so isolate `auth.spec.ts` from `pnpm test` by adjusting test file matching.
Update the Playwright/Vitest configuration so `e2e/**` is excluded from Vitest,
or rename the spec to an e2e-specific pattern like `auth.e2e.ts` and configure
Playwright `testMatch` accordingly. Use the `test.describe`-based spec in
`web/e2e/auth.spec.ts` as the file to relocate from Vitest’s scope.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cf16a350-4342-416f-a50a-989a39e47678
⛔ Files ignored due to path filters (1)
web/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
.github/workflows/web-ci.ymlRUNBOOK.mdbackend/grafana/provisioning/datasources/datasources.ymlweb/e2e/auth.spec.tsweb/package.jsonweb/playwright.config.ts
getByLabel('Password') was matching both 'Password' and 'Confirm password'
inputs due to Playwright's default partial matching.
Summary
/dashboardand/settings→/login) and login/register form rendering + validation. Wired into web CI with placeholder Firebase env vars (none of these tests touch Firebase).uid: prometheusto the datasource provisioning so the existing Backend Overview dashboard panels resolve correctly. Renamedprometheus.yml→datasources.ymlto stop VS Code's YAML extension from applying the wrong Prometheus scrape-config schema.RUNBOOK.mdwith grouped, actionable checkboxes across configuration, infrastructure, Firebase, observability, and mobile before going live.Test plan
cd web && pnpm test:e2eruns locally against a running dev servercd backend && make docker-run, open Grafana athttp://localhost:3001— Backend Overview dashboard loads with live panelsSummary by CodeRabbit