Skip to content

[511] User activity on Phoenix app resets the Rails session timeout #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cpreisinger wants to merge 1 commit into
base: eval-main
Choose a base branch
from
Draft

[511] User activity on Phoenix app resets the Rails session timeout #1620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion lib/web/controllers/session_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ defmodule Web.SessionController do
{:ok, userinfo} <- LoginGov.decode_jwt(id_token, public_key),
{:ok, user} =
Accounts.map_from_login(userinfo, id_token, Security.extract_remote_ip(conn)),
{:ok, user} <- Accounts.maybe_update_ial_level(user, userinfo) do
{:ok, user} <- Accounts.maybe_update_ial_level(user, userinfo),
:ok <- maybe_login_rails_app(user) do
conn
|> put_session(:user_token, user.token)
|> put_session(:session_timeout_at, new_session_timeout_at(Security.timeout_interval()))
Expand Down Expand Up @@ -181,6 +182,28 @@ defmodule Web.SessionController do
)
end

def maybe_login_rails_app(user) do
# Sign a JWT with user info
# jwt = signing method

headers = [
{"Login-Secret", System.get_env("LOGIN_SECRET")},
{"User-JWT", jwt}
]

url = ChallengeGov.Helpers.get_eval_url("external_login")

case HTTPoison.post(url, "", headers, follow_redirect: true) do
{:ok, %HTTPoison.Response{status_code: 200, headers: resp_headers}} ->
# Extract and set "Set-Cookie" resp_header to _challenge_platform_key
:ok

error ->
Logger.error("Failed to log in Rails app: #{inspect(error)}")
{:error, :rails_login_failed}
end
end

defp clear_rails_session(conn) do
domain = Application.get_env(:challenge_gov, :session_cookie_domain)
secure = Mix.env() != :dev
Expand Down
Loading