Conversation
Did I do it right? I've forgotten everything, which ought to be fun when I start the guide--now!
Contributor
Author
|
Related Issue #80 |
Contributor
|
For contributing.md, when I choose to view the file, I get a two-column, two-row table with "layout: page" and "title: contributing...." Is that just an artifact and won't show up on the live page? For testCaseGuide in HTML, when I try to view the file, I get the raw HTML. It looks good, but there's nothing like seeing it rendered to find errors. |
bletalien
approved these changes
Dec 30, 2021
Contributor
bletalien
left a comment
bletalien
left a comment
There was a problem hiding this comment.
See the comment I just left. Assuming that table is supposed to be there and the HTML renders properly, I'm good with this. Thanks for doing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bletalien - Markdown wasn't working for me so I had to switch to HTML to get the sample test case file to display correctly.
If this works, PR #142 and other contributing PRs can rest.