Skip to content

Merging forked repos - #423

Open
sonomirco wants to merge 1 commit into
masterfrom
dev/mibi/release-workflow
Open

Merging forked repos#423
sonomirco wants to merge 1 commit into
masterfrom
dev/mibi/release-workflow

Conversation

@sonomirco

Copy link
Copy Markdown
Collaborator

This implementation should solve the issue we have once we merge branches from forked repos.

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

Little fixing solves the issue of releasing from forked repos.

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

This implementation should solve the issue we have once we merge branches from forked repos.
@sonomirco sonomirco added bug 🐛 Issues describing a bug or pull requests fixing a bug. patch Pull requests requiring a patch version update according to semantic versioning. labels Aug 13, 2023
@sonomirco
sonomirco requested a review from d3ssy August 13, 2023 02:45
@sonomirco sonomirco self-assigned this Aug 13, 2023
@d3ssy
d3ssy self-requested a review August 27, 2023 09:09
@d3ssy

d3ssy commented Aug 27, 2023

Copy link
Copy Markdown
Collaborator

We can do this, but doesn't it open up the possibility for outside collaborators to run ANY action on this repo?!

The docs recommend enabling forks for outside collaborators but review and approve their workflows in the PR.

Tbh I never noticed that approval option in the PR... or looked for it lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐛 Issues describing a bug or pull requests fixing a bug. patch Pull requests requiring a patch version update according to semantic versioning.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants