Removal of TConstruct dependency#122
Open
akirapriva wants to merge 16 commits into
Open
Conversation
|
Can you please fix the conflicts against upstream changes and ping me for a review? |
DarkShadow44
requested changes
Apr 18, 2026
|
|
||
| public static void registerInventoryTabs() { | ||
| if (!Loader.isModLoaded("TConstruct") && TabRegistry.getTabList().size() < 1) { | ||
| if (TabRegistry.getTabList().size() < 1) { |
There was a problem hiding this comment.
Can this ever be false? Also, this won't work when having TConstruct installed - having two tabregistries is not really feasible, they'd compete for the same rendering space. Possibly an option to pull those tabs into GTNHLib? Either that or fall back to tconstruct dynamically. Architecturally cleaner is to avoid that code duplication though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see any reason to keep this dependency when you can just integrate into GC so people can use it in their own modpacks etc. too.