Fix server-side chat messages ignoring client locale#137
Merged
Conversation
Replace ChatComponentText(GCCoreUtil.translate(...)) with ChatComponentTranslation(...) across 16 files so that translation keys are resolved client-side in the player's own locale instead of always en_US on the dedicated server. Covers: BlockTelemetry, BlockNasaWorkbench, BlockShortRangeTelepad, BlockMachineMars, EntityAutoRocket, EntitySkeletonBoss, EntityCreeperBoss, EntitySlimeling, GCPlayerStats, ItemBasic, ItemFlag, ItemGrappleHook area, ItemAstroMiner, EntityAstroMiner, PacketSimple, CommandSpaceStation(Add|Remove)Owner.
Guvante
approved these changes
Apr 29, 2026
Guvante
left a comment
Guvante
left a comment
There was a problem hiding this comment.
I didn't verify that this was all of them but all of the changes LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatComponentText(GCCoreUtil.translate(...)), which resolves the translation key server-side — alwaysen_USon a dedicated server.ChatComponentTranslation(key)across 16 files so the key is sent to the client and rendered in the player's own language.EnumColor.REDprefix cases migrated toChatStyle+EnumChatFormatting.translateWithFormatcases migrated toChatComponentTranslation(key, args...).appendSibling(new ChatComponentTranslation(...)).BlockBeamReceiver.sendIncorrectSideMessage()andItemGrappleHookmessage left unchanged — both execute client-side only.