Create alternate player model rendering strategy to improve compatibility with Et Futurum#138
Draft
Dragovorn wants to merge 2 commits into
Draft
Create alternate player model rendering strategy to improve compatibility with Et Futurum#138Dragovorn wants to merge 2 commits into
Dragovorn wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create alternate player model rendering strategy using DelegatedModelBiped which is added in this Et Futurum PR: GTNewHorizons/Et-Futurum-Requiem#64 , improves compatibility with Et Futurum's 1.8 skin feature. There are likely rendering bugs with "edge cases" (most likely Mars Cryrogenic Chambers, because we're not registering PlayerRenderGC which fires an event on corpse rotate that cryogenic chambers supposedly hook into)
I'll be sure to clean up before unmarking this draft.
Neither rendering nor rendering optimization are my strong suits, please offer all improvements you can think of.