Skip to content

reduce runtime allocations from arc lamp algorithm #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alexdoru merged 2 commits into from
May 26, 2026
Merged

reduce runtime allocations from arc lamp algorithm #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9dc936
reduce runtime allocations from arc lamp algorithm
Alexdoru May 26, 2026
59a3547
Spotless apply for branch alex/arc-lamp for #140 (#141)
github-actions[bot] May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/micdoodle8/mods/galacticraft/core/tile/TileEntityArclamp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import it.unimi.dsi.fastutil.ints.IntIterator;
import it.unimi.dsi.fastutil.ints.IntList;
import it.unimi.dsi.fastutil.ints.IntOpenHashSet;
import it.unimi.dsi.fastutil.ints.IntSet;
import it.unimi.dsi.fastutil.longs.LongIterator;
import it.unimi.dsi.fastutil.longs.LongOpenHashSet;
import it.unimi.dsi.fastutil.longs.LongSet;
Expand Down Expand Up @@ -246,11 +245,14 @@ public void invalidate() {
super.invalidate();
}

// reuse set to avoid heavy allocation
private final IntOpenHashSet checked = new IntOpenHashSet();

public void lightArea() {
final Block breatheableAirID = GCBlocks.breatheableAir;
final Block brightAir = GCBlocks.brightAir;
final Block brightBreatheableAir = GCBlocks.brightBreatheableAir;
final IntSet checked = new IntOpenHashSet();
this.checked.clear();
final int baseX = this.xCoord, baseY = this.yCoord, baseZ = this.zCoord;

IntList currentLayer = new IntArrayList();
Expand Down